Rich text editor: improve performance when changing composer mode

[jmartinesp]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Store the current MessageComposerMode so we can diff and avoid unnecessary updates.

Also, only change some layout params for the editor if we don't want to animate the full screen change (keeps compatibility with both Element Android and Element X).

Motivation and context

Element X stopped properly responding to input as the renderComposerMode method was being triggered for each change (on Element Android this is not so noticeable). It also had some issues with resizing the editor properly.

As both apps share most of this code, it's better to also handle it properly here.

Screenshots / GIFs

Tests

It's quite difficult to test, as it wasn't a noticeable issue in Element Android.

• Enable the Rich Text Editor in Labs.
• Open a room.
• Select a message and edit or quote it, or reply to it.
• Exit the editing/replying/quoting mode.

There should be no issues when writing or 'flashes'.

Tested devices

• Physical
• Emulator
• OS version(s): 13

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[ElementBot]

	Fails
🚫	node failed.

Log

Error:  Error: Could not find the Dangerfile at tools/danger/dangerfile-lint.js - does a file exist at dangerfile-lint.js in tools/danger?.
    at /usr/src/danger/distribution/platforms/GitHub.js:166:27
    at step (/usr/src/danger/distribution/platforms/GitHub.js:44:23)
    at Object.next (/usr/src/danger/distribution/platforms/GitHub.js:25:53)
    at fulfilled (/usr/src/danger/distribution/platforms/GitHub.js:16:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
danger-results://tmp/danger-results-5ac9f88b.json

Generated by 🚫 dangerJS against 09f71af

[bmarty]

LGTM!

[bmarty]

It's worth noting that MessageComposerMode.Quote and MessageComposerMode.Reply are not data class, so maybe == will not work as expected here.

When replying to someone, then (without sending the message), reply to someone else, does the original sender name updates properly?

[jmartinesp]

It's worth noting that MessageComposerMode.Quote and MessageComposerMode.Reply are not data class, so maybe == will not work as expected here.

I just changed it so they're data classes too (I don't really remember why they weren't in the first place).

When replying to someone, then (without sending the message), reply to someone else, does the original sender name updates properly?

Yes, both before and after making Reply a data class.

[ElementBot]

	Warnings
⚠️	Please add a reviewer to your PR.

Generated by 🚫 dangerJS against f4c071b

[ElementBot]

	Warnings
⚠️	Please add a reviewer to your PR.

Generated by 🚫 dangerJS against d8bcaf4

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[bmarty]

LGTM!