Save m.local_notification_settings.<device-id> event in account_data (PSG-873) #7630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaturel
requested review from
a team and
ganfra
and removed request for
a team
mnaturel
commented
Nov 24, 2022
| ) { | ||
|
|
||
| suspend fun execute(session: Session) { | ||
| if (unifiedPushHelper.isBackgroundSync()) { |
Contributor
Author
There was a problem hiding this comment.
I am not sure this is the correct method to use to check if background sync is enabled. To be tested further to ensure it is working as expected.
Contributor
Author
There was a problem hiding this comment.
I have changed the implementation so that we can rely on this method.
Contributor
Author
|
In order to have correct behavior, I need to first fix some bugs on the notification method selection process. |
ganfra
approved these changes
Nov 29, 2022
Member
ganfra
left a comment
ganfra
left a comment
There was a problem hiding this comment.
LGTM, thanks for all the tests.
mnaturel
force-pushed
the
feature/mna/remote-notification-toggle-account-data
branch
from
a9121cd to
54d0e84
Compare
mnaturel
force-pushed
the
feature/mna/remote-notification-toggle-account-data
branch
from
54d0e84 to
6c7ef69
Compare
mnaturel
changed the base branch from
develop
to
fix/mna/unified-push-selection
Contributor
Author
|
@ganfra Could you take a look again please? I had to change several things which were not working correctly. I have also rebased my work on this PR in which I refactored some logic for unifiedPush to fix several issues. |
15 tasks
added 13 commits
December 5, 2022 09:43
… be toggled using account data
added 8 commits
December 5, 2022 09:43
mnaturel
force-pushed
the
fix/mna/unified-push-selection
branch
from
b30dda7 to
f8c59f6
Compare
mnaturel
force-pushed
the
feature/mna/remote-notification-toggle-account-data
branch
from
8d1b245 to
635f975
Compare
|
Kudos, SonarCloud Quality Gate passed! |
mnaturel
deleted the
feature/mna/remote-notification-toggle-account-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
When background sync is used, on session start and each time we switch on background sync, account data event "org.matrix.msc3890.local_notification_settings." is updated.
When switching from background sync to regular push notifications method, any existing account data event is updated with empty content (API to delete an account data event is not available yet).
Also in this PR: renaming some notifications related use cases for consistency.
Motivation and context
Closes #7596
Screenshots / GIFs
Tests
Tests should be performed with both the GPlay and FDroid variant.
Tested devices
Checklist