Skip to content

[Device Management] Long session names not rendered well (PSG-820) #7312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mnaturel merged 3 commits into from
Oct 7, 2022
Merged

[Device Management] Long session names not rendered well (PSG-820) #7312

mnaturel merged 3 commits into from
Oct 7, 2022

Conversation

@mnaturel
Copy link
Contributor

@mnaturel mnaturel commented Oct 7, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fixing issues in UI when session have long names in the session overview and details screens.

Motivation and context

Closes #7310

Screenshots / GIFs

Before After

Tests

  • Enable the new device management feature flag
  • Go to Settings -> Security & Privacy -> Show all sessions (WIP, V2)
  • Go to session overview screen for a session
  • Check the name is well displayed
  • Go to session details screen
  • Check the display is correct

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review October 7, 2022 09:41
@mnaturel mnaturel requested review from a team and Florian14 and removed request for a team October 7, 2022 09:41
@mnaturel mnaturel changed the title [Device Management] Long session names not (PSG-820) [Device Management] Long session names not rendered well (PSG-820) Oct 7, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Florian14
Florian14 approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in the second screen, there is no "verify" button and the shield is black but I don't think this is related to your changes

@mnaturel
Copy link
Contributor Author

mnaturel commented Oct 7, 2022

LGTM, in the second screen, there is no "verify" button and the shield is black but I don't think this is related to your changes

Yes this is not related. It is because my current session was not verified: in this case, we don't allow to verify another session.

@mnaturel mnaturel merged commit 9827ffb into develop Oct 7, 2022
@mnaturel mnaturel deleted the fix/mna/device-manager-long-session-name branch October 7, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Florian14 Florian14 Florian14 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Device Management] Long session names not handled well

3 participants

@mnaturel @Florian14