Skip to content

Conversation

@mnaturel
Copy link
Contributor

@mnaturel mnaturel commented Oct 6, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adding Application section in the session details screen.
Adding extended device info in the Device section of the session details screen depending on the device type.

Motivation and context

Closes #7294

Screenshots / GIFs


Tests

  • Login to an account in https://synapse-prefill.lab.element.dev/ (Synapse deployment with experimental feature flags for MSC3852 (exposure of user agent))
  • Enable the new device manager feature flag
  • Go to Settings -> Security & Privacy -> Show all sessions (WIP, V2)
  • Go to the session details screen of session with different types
  • Check the information is correct

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review October 6, 2022 12:53
@mnaturel mnaturel requested review from a team and bmarty and removed request for a team October 6, 2022 12:53
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mnaturel mnaturel force-pushed the feature/mna/device-manager-account-data branch from 71f15d4 to 4aca1dc Compare October 11, 2022 12:44
@mnaturel mnaturel force-pushed the feature/mna/device-manager-extended-details branch from 8c026fd to 72f9dad Compare October 11, 2022 12:46
@mnaturel mnaturel force-pushed the feature/mna/device-manager-extended-details branch from 72f9dad to b7190c2 Compare October 11, 2022 13:23
@mnaturel mnaturel added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Oct 12, 2022
Base automatically changed from feature/mna/device-manager-account-data to develop October 12, 2022 13:41
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

26.5% 26.5% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel merged commit f8f416e into develop Oct 12, 2022
@mnaturel mnaturel deleted the feature/mna/device-manager-extended-details branch October 12, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-NextRelease For issues and PRs which should be included in the NextRelease.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Device Management] Render extended device info

3 participants