Skip to content

Conversation

@BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Oct 4, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fixes #6723
Verification events sent in e2ee rooms should bypass the encrypt to verified devices only option. If not it renders verification impossible.

Motivation and context

As per spec:

When using in-room messages and the room has encryption enabled, clients should ensure that encryption does not hinder the verification. For example, if the verification messages are encrypted, clients must ensure that all the recipient’s unverified devices receive the keys necessary to decrypt the messages, even if they would normally not be given the keys to decrypt messages in the room. Alternatively, verification messages may be sent unencrypted, though this is not encouraged.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@BillCarsonFr BillCarsonFr force-pushed the feature/bca/hinder_verification branch from fbe126d to b63ee68 Compare October 4, 2022 21:58
@BillCarsonFr BillCarsonFr requested review from a team and Florian14 and removed request for a team October 4, 2022 21:59
Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillCarsonFr BillCarsonFr force-pushed the feature/bca/hinder_verification branch from e58562f to fddedda Compare October 5, 2022 08:42
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't verify user when option to send keys to verified devices only is selected

3 participants