Skip to content

Conversation

@pt2121
Copy link
Contributor

@pt2121 pt2121 commented Sep 10, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

When showUserCodeCardNameText is gone, showUserCodeCardUserIdText top constraint is missing. Updated the top margin when the referenced view is gone.
54dp is from adding up both views margin tops (50dp + 4dp).

Motivation and context

Addressing #5424

Screenshots / GIFs

01
02

Tests

I tested this from the old UI flow and followed the steps in #5424

  1. Enable the old flow
  2. Open the hamburger menu on the top left
  3. Tap the QR code icon

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 12 and also API 21

Checklist

Signed-off-by: Prat T <pt2121@users.noreply.github.com>
@pt2121 pt2121 marked this pull request as ready for review September 10, 2022 17:57
@bmarty bmarty self-requested a review September 12, 2022 15:26
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@bmarty bmarty merged commit 7f766ee into element-hq:develop Sep 12, 2022
@pt2121 pt2121 deleted the pt/5424-qr branch September 12, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants