Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libopus encoder for devices that lack the official codec #7012

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Try to detect if the OS has support for the Opus encoder, if it doesn't, use the bundled libopus one.

Motivation and context

See #7010 .

Tests

Testing this is probably impossible unless you're one of the few affected users. You could force the check to return true and verify that VoiceRecorderL is used instead, but that's not really helpful.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 11

Checklist

@jmartinesp jmartinesp requested a review from a team September 5, 2022 13:36
@jmartinesp jmartinesp self-assigned this Sep 5, 2022
@jmartinesp jmartinesp requested review from Florian14 and removed request for a team September 5, 2022 13:36
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jmartinesp jmartinesp merged commit 0a1c756 into develop Sep 6, 2022
@jmartinesp jmartinesp deleted the fix/use-libopus-for-devices-with-no-encoder branch September 6, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants