empty state for new invites screen #6986
Conversation
fedrunov
requested review from
a team and
ouchadam
and removed request for
a team
fedrunov
added
the
Z-NextRelease
vector/src/main/java/im/vector/app/features/home/room/list/home/invites/InvitesViewModel.kt
Outdated
Show resolved
Hide resolved
| } | ||
| pagedList.asFlow() | ||
| .map { | ||
| if (it.isEmpty()) { |
There was a problem hiding this comment.
out of interest, is an empty result only returned after the pagedList has finished loading?
or is it possible for it to emit an empty state instantly?
There was a problem hiding this comment.
up to my tests it emits empty list only when there are no invites
| is InvitesContentState.Content -> { | ||
| views.invitesStateView.state = StateView.State.Content | ||
| Suppress("UNCHECKED_CAST") | ||
| controller.submitList(it.content as? PagedList<RoomSummary>) |
There was a problem hiding this comment.
is this cast (and suppress) needed?
There was a problem hiding this comment.
no, it's a leftover from attempt to make solution more generic
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
LGTM, some minor remarks though.
vector/src/main/java/im/vector/app/features/home/room/list/home/invites/InvitesViewModel.kt
Outdated
Show resolved
Hide resolved
| message = stringProvider.getString(R.string.invites_empty_message) | ||
| ) | ||
| } else { | ||
| invitesCount = it.loadedCount |
There was a problem hiding this comment.
This will work since we will test only if this is equal to 1, but I think it's more correct to use it.size()
There was a problem hiding this comment.
it.size() will also return placeholders (if there are any), while here we are interested in exact count without them
There was a problem hiding this comment.
from my understanding, the exact count is returned by size(). loadedCount does not include placeholders (= not loaded data, but which exist). If we have for instance 120 invites, there is maybe a risk that loadedCount return 0, or 1 (and so we have a bug), while size() returns 120, during the time the data are not yet loaded.
Anyway the risk is very low I think, and probably temporary, since more data will be loaded to be displayed.
vector/src/main/java/im/vector/app/features/home/room/list/home/invites/InvitesViewState.kt
Outdated
Show resolved
Hide resolved
| android:fastScrollEnabled="true" | ||
| android:overScrollMode="always" | ||
| android:scrollbars="vertical" | ||
| app:layout_behavior="@string/appbar_scrolling_view_behavior" |
There was a problem hiding this comment.
To double check, is it OK to remove this layout_behavior?
There was a problem hiding this comment.
yes, we don't need it for state view
|
SonarCloud Quality Gate failed. |
|
Test |
Type of change
Content
new invites screen should also present empty state
Motivation and context
closes #6876
part of #6502
Screenshots / GIFs