Fix crash on PIN code settings screen #6980

jmartinesp · 2022-08-31T14:06:54Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Made VectorSettingsPinFragment.biometricHelper lazy so it's not instantiated before biometricHelperFactory is injected.

Motivation and context

See #6979.

Tests

Go to Settings > Security & Privacy > Protect access.

Tested devices

Physical
Emulator
OS version(s): 12.

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

bmarty · 2022-08-31T15:55:29Z

vector/src/main/java/im/vector/app/features/settings/VectorSettingsPinFragment.kt

-    private val biometricHelper = biometricHelperFactory.create(defaultLockScreenConfiguration.copy(mode = LockScreenMode.CREATE))
+    private val biometricHelper by lazy {
+        biometricHelperFactory.create(defaultLockScreenConfiguration.copy(mode = LockScreenMode.CREATE))
+    }


it could also be a lateinit var and be created in fun onCreate(). Not sure if it's better, but at least it will remove the overhead of using by lazy.

(IMO we should use by lazy when on object would eventually be not used - which is not the case here)

Sorry, when it was approved I enabled automatic merge and by the time I read that message it was already merged. I can open a new PR changing lazy to lateinit and instantiate it in onCreate if you think it's worth it.