Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new app layouts invites #6911

Merged
merged 3 commits into from
Aug 25, 2022
Merged

new app layouts invites #6911

merged 3 commits into from
Aug 25, 2022

Conversation

fedrunov
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Invites for new App Layout

Motivation and context

part of #6502
closes #6889

Screenshots / GIFs

Light Dark Black
light black dark

output-optimised

ericdecanini
ericdecanini approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@ericdecanini ericdecanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's worth noting that there's an issue to write tests for not only invites but of Edit Layout in general
#6509

Also Dark and Black screenshots are reversed :)

NIkita Fedrunov added 2 commits August 25, 2022 13:41
Merge branch 'develop' into feature/nfe/edit_layout_invites
80bfbc7 
# Conflicts:
#	vector/src/main/java/im/vector/app/core/di/FragmentModule.kt
#	vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListFragment.kt
changelog
25093c6
@ElementBot
Copy link

ElementBot commented Aug 25, 2022 •
edited
Loading

Warnings
⚠️

vector/src/main/AndroidManifest.xml#L79 - The attribute android:allowBackup is deprecated from Android 12 and higher and may be removed in future versions. Consider adding the attribute android:dataExtractionRules specifying an @xml resource which configures cloud backups and device transfers on Android 12 and higher.
⚠️

vector/src/main/AndroidManifest.xml#L79 - The attribute android:allowBackup is deprecated from Android 12 and higher and may be removed in future versions. Consider adding the attribute android:dataExtractionRules specifying an @xml resource which configures cloud backups and device transfers on Android 12 and higher.
⚠️

vector/src/main/AndroidManifest.xml#L232 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️

vector/src/main/AndroidManifest.xml#L232 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️

vector/src/main/AndroidManifest.xml#L235 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️

vector/src/main/AndroidManifest.xml#L235 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️

vector/src/main/AndroidManifest.xml#L289 - Expecting android:screenOrientation="unspecified" or "fullSensor" for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️

vector/src/main/AndroidManifest.xml#L289 - Expecting android:screenOrientation="unspecified" or "fullSensor" for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️

vector/src/main/AndroidManifest.xml#L425 - Exported receiver does not require permission
⚠️

vector/src/main/AndroidManifest.xml#L425 - Exported receiver does not require permission
⚠️

vector/src/main/res/layout/item_invites_count.xml#L7 - Possible overdraw: Root element paints background ?vctr_toolbar_background with a theme that also paints a background (inferred theme is @style/Theme.Vector.Light)
⚠️

vector/src/main/res/layout/item_invites_count.xml#L7 - Possible overdraw: Root element paints background ?vctr_toolbar_background with a theme that also paints a background (inferred theme is @style/Theme.Vector.Light)

Generated by 🚫 dangerJS against 25093c6

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@fedrunov fedrunov merged commit 70cfe00 into develop Aug 25, 2022
@fedrunov fedrunov deleted the feature/nfe/edit_layout_invites branch August 25, 2022 14:34
onurays added a commit that referenced this pull request Aug 26, 2022
@onurays
Merge branch 'develop' into feature/ons/device_manager_current_session
7a3a5ae 
* develop: (169 commits)
  new app layouts invites (#6911)
  bottom navigation tabs are removed for AppLayout (#6905)
  focus input when changing server address
  Fix copyright
  Improve createRoomThreePidEvents for clarity
  Remove roomCreatorUserId and use current userId by default
  Remove useless explicit field type
  Change visibility of LocalRoomThirdPartyInviteContent to internal
  Remove useless apply in CreateLocalRoomStateEventsTask
  Update doc
  Extract condition to reduce code complexity
  Verify tombstone event
  Remove safe call
  Add unit tests for CreateRoomFromLocalRoomTask
  Add unit tests for CreateLocalRoomStateEventsTask
  Set stateKey as empty by default
  Create local room state events in dedicated task
  Fix local events generation following the specification
  Update CreateRoomParams from the potential FeaturePreset before persisting
  Persists CreateRoomParams into LocalRoomSummaryEntity
  ...

# Conflicts:
#	vector/src/main/java/im/vector/app/features/settings/devices/v2/VectorSettingsDevicesFragment.kt
onurays added a commit that referenced this pull request Aug 26, 2022
@onurays
Merge branch 'feature/ons/device_manager_current_session' into featur…
2c6c23d 
…e/ons/device_manager_other_session_list

* feature/ons/device_manager_current_session: (169 commits)
  new app layouts invites (#6911)
  bottom navigation tabs are removed for AppLayout (#6905)
  focus input when changing server address
  Fix copyright
  Improve createRoomThreePidEvents for clarity
  Remove roomCreatorUserId and use current userId by default
  Remove useless explicit field type
  Change visibility of LocalRoomThirdPartyInviteContent to internal
  Remove useless apply in CreateLocalRoomStateEventsTask
  Update doc
  Extract condition to reduce code complexity
  Verify tombstone event
  Remove safe call
  Add unit tests for CreateRoomFromLocalRoomTask
  Add unit tests for CreateLocalRoomStateEventsTask
  Set stateKey as empty by default
  Create local room state events in dedicated task
  Fix local events generation following the specification
  Update CreateRoomParams from the potential FeaturePreset before persisting
  Persists CreateRoomParams into LocalRoomSummaryEntity
  ...

# Conflicts:
#	vector/src/main/java/im/vector/app/features/settings/devices/v2/VectorSettingsDevicesFragment.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdecanini ericdecanini ericdecanini approved these changes

Assignees
No one assigned
Labels
Z-AppLayout
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App Layout: Invites
4 participants
@fedrunov @ElementBot @ericdecanini @MadLittleMods