Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Login2 proof of concept #6833

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Conversation

ouchadam
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Removes all Login2 related classes and resources, this flow has been superseded by the FTUE changes

Motivation and context

#5974 Removes the no longer needed Login2 PoC

Screenshots / GIFs

No UI changes

Tests

  • open the debug menu
  • notice Login2 is no longer an option

Tested devices

  • Physical
  • Emulator
  • OS version(s):

@ouchadam ouchadam requested review from a team and ericdecanini and removed request for a team August 15, 2022 11:00
@ouchadam ouchadam changed the title Removing Login proof of concept Removing Login2 proof of concept Aug 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ouchadam ouchadam mentioned this pull request Aug 15, 2022
6 tasks
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ouchadam ouchadam merged commit 74d99b1 into develop Aug 16, 2022
@ouchadam ouchadam deleted the feature/adm/removing-login-poc branch August 16, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants