Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Devices Management] Header view for sessions lists in new layout (PSG-668) #6807

Merged
merged 6 commits into from
Aug 15, 2022

Conversation

mnaturel
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adding a nex custom view for headers which will be used in sessions lists in the new layout.

Motivation and context

See #6806

Screenshots / GIFs

Tests

  • Enable the new device management feature flag
  • Go to "Security & Privacy" settings
  • Press the "Show all sessions (V2, WIP)" entry
  • Check the header for "Other sessions" section is visible
  • Press "Learn more"
  • Check there is a toast displayed

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel changed the title [Devices Management] Other sessions section in new layout (PSG-668) [Devices Management] Header view for sessions lists in new layout (PSG-668) Aug 11, 2022
@mnaturel mnaturel requested a review from onurays August 11, 2022 12:37
@mnaturel mnaturel marked this pull request as ready for review August 11, 2022 12:37
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just added minor commits.

@onurays onurays merged commit 6c65b0a into develop Aug 15, 2022
@onurays onurays deleted the feature/mna/device-management-header-list branch August 15, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants