Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that setting up a FCM Rewrite Proxy is not necessary for use of the UnifiedPush FCM distributor. #6727

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

anoadragon453
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other: Documentation

Content

After #6228 was merged, an enterprise chimed in with worry that they'd need to set up an FCM Rewrite Proxy in order to continue using FCM, as is documented here.

After discussing with the UnifiedPush developers however, it appears that Sygnal replaces the need for this in the case of Element Android.

This change adds a bit to the documentation to clarify this.

Checklist

@anoadragon453 anoadragon453 changed the title Clarify that an FCM Rewrite Proxy is not necessary Clarify that setting up a FCM Rewrite Proxy is not necessary for use of the UnifiedPush FCM distributor. Aug 3, 2022
@anoadragon453 anoadragon453 marked this pull request as ready for review August 3, 2022 13:26
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit 5143ef9 into element-hq:develop Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants