[Location sharing] Invisible text on map symbol #6688
Conversation
mnaturel
requested review from
a team and
ouchadam
and removed request for
a team
|
Kudos, SonarCloud Quality Gate passed!
|
|
it would be handy to have screenshots for this fix 🙏 |
| @@ -162,7 +163,7 @@ class MapTilerMapView @JvmOverloads constructor( | |||
| pinDrawable?.let { drawable -> | |||
| if (!safeMapRefs.style.isFullyLoaded || | |||
| safeMapRefs.style.getImage(state.pinId) == null) { | |||
| safeMapRefs.style.addImage(state.pinId, drawable) | |||
| safeMapRefs.style.addImage(state.pinId, drawable.toBitmap()) | |||
There was a problem hiding this comment.
do we know why this behaviour is different?
addImage(drawable) chains into BitmapUtils.getBitmapFromDrawable(drawable) which in turn calls Bitmap.createBitmap(drawable.getIntrinsicWidth(), drawable.getIntrinsicHeight(), Bitmap.Config.ARGB_8888)
whereas drawable.toBitmap() calls Bitmap.createBitmap(width, height, config ?: Config.ARGB_8888)
I would have thought them to be equivalent? 🤔
There was a problem hiding this comment.
I wasn't curious enough to understand... Let me look at it to answer this question.
There was a problem hiding this comment.
After some investigation it seems the only difference I see is that in BitmapUtils.getBitmapFromDrawable() they are creating a new drawable with Drawable drawable = constantState.newDrawable().mutate(); and then the bitmap is created from this new drawable. I suspect the Text part disappears due to this call. In the doc, it says density dependent properties may not be scaled well (https://developer.android.com/reference/android/graphics/drawable/Drawable.ConstantState#newDrawable()). Testing with following code leads to the same issue:
val bitmap = drawable.constantState?.newDrawable()?.toBitmap()
bitmap?.let { safeMapRefs.style.addImage(state.pinId, it) }
There was a problem hiding this comment.
great to know, thanks for looking into it! 💯
I agree. I updated the description with captures. |
Type of change
Content
Convert the map symbol drawable to bitmap to be able to see text on it.
Motivation and context
Closes #6687
Screenshots / GIFs
Tests
Tested devices
Checklist