Skip to content

Conversation

@mnaturel
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Canceling the infinite animations when the view is destroyed.

Motivation and context

Closes #6663

Screenshots / GIFs

Tests

Easier to enable LeakCanary to check everything is correct.

  • Go to a room where there are threads
  • Open a thread timeline
  • Press back
  • Open again the thread timeline
  • Press back
  • Check there is no slowness
  • If leakcanary is enabled, check there is no leak detected which is related to ObjectAnimator

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel added the PR-Small PR with less than 20 updated lines label Jul 28, 2022
@mnaturel mnaturel marked this pull request as ready for review July 28, 2022 08:18
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ouchadam ouchadam added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Jul 28, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mnaturel mnaturel merged commit d60683d into develop Jul 28, 2022
@mnaturel mnaturel deleted the fix/mna/cancel-infinite-animation branch July 28, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Small PR with less than 20 updated lines Z-NextRelease For issues and PRs which should be included in the NextRelease.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ObjectAnimators are not canceled in TypingMessageDotsView

4 participants