Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTUE - Test session feedback #6649

Merged
merged 10 commits into from
Jul 27, 2022
Merged

FTUE - Test session feedback #6649

merged 10 commits into from
Jul 27, 2022

Conversation

ouchadam
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Updates email verification, server selection and server heading copy
  • Fixes the server selection next button being enabled when the server url is empty
  • Fixes the keyboard done button allowing the account creation password minimum to be bypassed
  • Fixes the email verification loading spinner causing the screen to change margin size and hides the spinner upon re-sending the email
  • Applies a friendlier error message when resetting a password without confirming the email first

Motivation and context

To address the issues found during testing #6620 #6621

Screenshots / GIFs

RESET PASSWORD ERROR DISABLED SERVER URL DISABLE KEYBOARD DONE
Screenshot_20220726_162653 disable-server-url disabled-keyboard-done

Tests

Walk through the FTUE - #6620

Tested devices

  • Physical
  • Emulator
  • OS version(s): 28

@ouchadam ouchadam added the Z-FTUE Issue is relevant to the first time use project or experience label Jul 27, 2022
bmarty
bmarty approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ouchadam ouchadam merged commit 067a030 into develop Jul 27, 2022
@ouchadam ouchadam deleted the feature/adm/auth-testing-results branch July 27, 2022 11:09
@ouchadam ouchadam mentioned this pull request Jul 27, 2022
Closed
19 tasks
@ouchadam ouchadam mentioned this pull request Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
Z-FTUE Issue is relevant to the first time use project or experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouchadam @bmarty