Put EC permission shortcuts behind labs flag (PSG-630) #6634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Marbach <[email protected]>
Signed-off-by: Johannes Marbach <[email protected]>
Johennes
commented
Jul 25, 2022
| val actions = mutableListOf<RemoteAction>() | ||
| val intent = Intent(ACTION_MEDIA_CONTROL).putExtra(EXTRA_CONTROL_TYPE, CONTROL_TYPE_HANGUP) | ||
| val pendingIntent = PendingIntent.getBroadcast(this, REQUEST_CODE_HANGUP, intent, 0) | ||
| val pendingIntent = PendingIntent.getBroadcast(this, REQUEST_CODE_HANGUP, intent, FLAG_IMMUTABLE) |
Contributor
Author
There was a problem hiding this comment.
This isn't strictly related to the intent of this PR but the widget kept crashing for me without this.
Contributor
There was a problem hiding this comment.
Yes it seems mandatory started from Android 12: https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Johannes Marbach [email protected]
Type of change
Content
This is a follow-up on #6616 that puts the Element Call permission shortcuts behind a labs flag. Anyone can create a false widget of type
io.element.calland silently acquire permissions so we don't want to enable this behavior by default.Tests
Can be tested e.g. in #ecwidgettest:matrix.org
Tested devices
Checklist
CC @onurays