Skip to content

[Location sharing] - OnTap on the top live status bar, display the expanded map view (PSG-614) #6626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnaturel merged 3 commits into from
Jul 25, 2022
Merged

[Location sharing] - OnTap on the top live status bar, display the expanded map view (PSG-614) #6626

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70c9c8a
Navigate to location live map when tapping the live status bar in tim…
Jul 22, 2022
03ebad1
Adding changelog entry
Jul 22, 2022
989c2ee
Removing non necessary root binding
Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/6625.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[Location sharing] - OnTap on the top live status bar, display the expanded map view
3 changes: 3 additions & 0 deletions vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,9 @@ class TimelineFragment @Inject constructor(
views.locationLiveStatusIndicator.stopButton.debouncedClicks {
timelineViewModel.handle(RoomDetailAction.StopLiveLocationSharing)
}
views.locationLiveStatusIndicator.root.debouncedClicks {

@bmarty bmarty Jul 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but is it mandatory to use root?

I was wondering if views.locationLiveStatusIndicator.debouncedClicks { would work the same way.

@mnaturel mnaturel Jul 25, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed, the root is not needed, I removed it.

navigateToLocationLiveMap()
}
}

private fun joinJitsiRoom(jitsiWidget: Widget, enableVideo: Boolean) {
Expand Down
4 changes: 4 additions & 0 deletions vector/src/main/java/im/vector/app/features/location/live/LocationLiveStatusView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package im.vector.app.features.location.live
import android.content.Context
import android.util.AttributeSet
import android.view.LayoutInflater
import android.view.View
import android.widget.Button
import androidx.constraintlayout.widget.ConstraintLayout
import im.vector.app.databinding.ViewLocationLiveStatusBinding
Expand All @@ -34,6 +35,9 @@ class LocationLiveStatusView @JvmOverloads constructor(
this
)

val root: View
get() = binding.root

val stopButton: Button
get() = binding.locationLiveStatusStop
}