Skip to content

Do not log the live location of the user (PSG-63) #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onurays merged 3 commits into from
Jul 19, 2022
Merged

Do not log the live location of the user (PSG-63) #6579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac32850
Do not log the live location of the user.
onurays Jul 18, 2022
82fed20
Changelog added.
onurays Jul 18, 2022
55a5752
Remove unused import.
onurays Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/6579.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not log the live location of the user
3 changes: 1 addition & 2 deletions ...tor/app/features/home/room/detail/timeline/factory/LiveLocationShareMessageItemFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import im.vector.app.features.location.toLocationData
import org.matrix.android.sdk.api.session.Session
import org.matrix.android.sdk.api.session.room.timeline.TimelineEvent
import org.threeten.bp.LocalDateTime
import timber.log.Timber
import javax.inject.Inject

class LiveLocationShareMessageItemFactory @Inject constructor(
Expand Down Expand Up @@ -135,7 +134,7 @@ class LiveLocationShareMessageItemFactory @Inject constructor(
liveLocationShareSummaryData.lastGeoUri.orEmpty(),
getEndOfLiveDateTime(liveLocationShareSummaryData)
)
}.also { viewState -> Timber.d("computed viewState: $viewState") }
}
}

private fun getEndOfLiveDateTime(liveLocationShareSummaryData: LiveLocationShareSummaryData): LocalDateTime? {
Expand Down