Skip to content

Conversation

@Johennes
Copy link
Contributor

@Johennes Johennes commented Jul 7, 2022

This suppresses the web view / checkbox permission dialog and redirects straight to the system permission dialog (in case it's needed).

Signed-off-by: Johannes Marbach <johannesm@element.io>
@Johennes Johennes requested a review from onurays July 7, 2022 06:47
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Ktlint Results

👎Failed
vector 🔸 features/widgets/ptt/BluetoothLowEnergyDeviceScanner.kt:23:1: Unused import (no-unused-imports)
vector 🔸 features/widgets/ptt/BluetoothLowEnergyService.kt:19:1: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end (import-ordering)
vector 🔸 features/widgets/WidgetFragment.kt:21:1: Unused import (no-unused-imports)
vector 🔸 features/widgets/WidgetFragment.kt:22:1: Unused import (no-unused-imports)
vector 🔸 features/widgets/WidgetFragment.kt:92:1: Needless blank line(s) (no-consecutive-blank-lines)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thank you!

@onurays onurays merged commit ed1b861 into feature/ons/ptt_bluetooth Jul 7, 2022
@onurays onurays deleted the johannes/shortcut-permissions branch July 7, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants