Skip to content

Conversation

@dbkr
Copy link
Member

@dbkr dbkr commented Jul 5, 2022

by setting the appropriate descriptor, which apparently is not
a thing that setCharacteristicNotification does

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

by setting the appropriate descriptor, which apparently is not
a thing that setCharacteristicNotification does
@dbkr dbkr marked this pull request as ready for review July 5, 2022 17:12
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Ktlint Results

👎Failed
vector 🔸 features/widgets/ptt/BluetoothLowEnergyService.kt:19:1: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end (import-ordering)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the test purpose. Thanks!

@onurays onurays merged commit cea7193 into feature/ons/ptt_bluetooth Jul 6, 2022
@onurays onurays deleted the dbkr/ptt_enable_notifications branch July 6, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants