Promote live location labs flag [PSF-959] #6350
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Promote live location labs flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /* | ||
| * Copyright (c) 2022 New Vector Ltd | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package im.vector.app.features.location.live | ||
|
|
||
| import android.os.Bundle | ||
| import android.view.LayoutInflater | ||
| import android.view.View | ||
| import android.view.ViewGroup | ||
| import im.vector.app.core.platform.VectorBaseBottomSheetDialogFragment | ||
| import im.vector.app.databinding.BottomSheetLiveLocationLabsFlagPromotionBinding | ||
|
|
||
| /** | ||
| * Bottom sheet to warn users that feature is still in active development. Users are able to enable labs flag by using the switch in this bottom sheet. | ||
| * This should not be shown if the user already enabled the labs flag. | ||
| */ | ||
| class LiveLocationLabsFlagPromotionBottomSheet : | ||
| VectorBaseBottomSheetDialogFragment<BottomSheetLiveLocationLabsFlagPromotionBinding>() { | ||
|
|
||
| override val showExpanded = true | ||
|
|
||
| override fun getBinding(inflater: LayoutInflater, container: ViewGroup?): BottomSheetLiveLocationLabsFlagPromotionBinding { | ||
| return BottomSheetLiveLocationLabsFlagPromotionBinding.inflate(inflater, container, false) | ||
| } | ||
|
|
||
| override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | ||
| super.onViewCreated(view, savedInstanceState) | ||
| initOkButton() | ||
| } | ||
|
|
||
| private fun initOkButton() { | ||
| views.promoteLiveLocationFlagOkButton.debouncedClicks { | ||
| val enableLabsFlag = views.promoteLiveLocationFlagSwitch.isChecked | ||
| resultListener?.onBottomSheetResult(ResultListener.RESULT_OK, enableLabsFlag) | ||
| dismiss() | ||
| } | ||
| } | ||
|
|
||
| companion object { | ||
| fun newInstance(resultListener: ResultListener): LiveLocationLabsFlagPromotionBottomSheet { | ||
| return LiveLocationLabsFlagPromotionBottomSheet().also { | ||
| it.resultListener = resultListener | ||
|
Member
There was a problem hiding this comment. Not a big big deal, but we will loose the listener if the Fragment is recreated by system |
||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:background="?colorSurface" | ||
| android:orientation="vertical" | ||
| android:paddingHorizontal="16dp" | ||
| android:paddingBottom="8dp"> | ||
|
|
||
| <ImageView | ||
| android:layout_width="60dp" | ||
| android:layout_height="60dp" | ||
| android:layout_gravity="center_horizontal" | ||
| android:layout_marginTop="30dp" | ||
| android:background="@drawable/circle" | ||
| android:backgroundTint="?vctr_live_location" | ||
| android:importantForAccessibility="no" | ||
| android:padding="4dp" | ||
| android:src="@drawable/ic_attachment_location_live_white" /> | ||
|
|
||
| <TextView | ||
| style="@style/TextAppearance.Vector.Headline.Medium" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center" | ||
| android:layout_marginTop="24dp" | ||
| android:text="@string/live_location_labs_promotion_title" /> | ||
|
|
||
| <TextView | ||
| style="@style/TextAppearance.Vector.Body" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center" | ||
| android:layout_marginTop="24dp" | ||
| android:gravity="center" | ||
| android:text="@string/live_location_labs_promotion_description" /> | ||
|
|
||
| <com.google.android.material.switchmaterial.SwitchMaterial | ||
| android:id="@+id/promoteLiveLocationFlagSwitch" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center" | ||
| android:layout_marginTop="40dp" | ||
| android:text="@string/live_location_labs_promotion_switch_title" | ||
| app:switchPadding="8dp" /> | ||
|
|
||
| <Button | ||
| android:id="@+id/promoteLiveLocationFlagOkButton" | ||
| style="@style/Widget.Vector.Button.Positive" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="32dp" | ||
| android:text="@string/ok" /> | ||
|
|
||
| </LinearLayout> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment above could be replaced by extracting this condition to its own function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, done.