Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix animated images only autoplaying sometimes #6215

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Fix animated images only autoplaying sometimes #6215

merged 3 commits into from
Oct 4, 2022

Commits on Aug 21, 2022

  1. Implement Mode.ANIMATED_THUMBNAIL used for autoplaying animated images 

    This patch introduces a new `ImageContentRenderer` mode used for
autoplaying animated images. The mode shares url resolving semantics
with `FULL_SIZE` and `STICKER`, as such not just fetching thumbnail data
but shares sizing semantics with `THUMBNAIL` (scaling by image height).

This change fixes animated images not playing in cases in which only a
static thumbnail would be loaded.

This new mode will only be chosen if the message content is actually a
playable image, as such limiting bandwith usage to the required amount
by avoiding to load normal images fully (still fetching animated images
will increase bandwith usage as a whole of course).

Signed-off-by: networkException <[email protected]>
    @networkException
    networkException committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    dccc643 View commit details
    Browse the repository at this point in the history

  2. ImageContentRenderer: Only animate images using ANIMATED_THUMBNAIL mode 

    This patch removes the dependency on `VectorSettings` as well as only
enable animated rendering if the image is actually playable.

Signed-off-by: networkException <[email protected]>
    @networkException
    networkException committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    5fede49 View commit details
    Browse the repository at this point in the history

  3. Changelog: Add .bugfix entry for pull request element-hq#6215 

    Signed-off-by: networkException <[email protected]>
    @networkException
    networkException committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    2bca94d View commit details
    Browse the repository at this point in the history