-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Location sharing] - Declare background location permission in release manifest (PSF-1039) #6159
[Location sharing] - Declare background location permission in release manifest (PSF-1039) #6159
Conversation
@@ -0,0 +1 @@ | |||
[Live location sharing] - Declare the background location permission access into the release variant Manifest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is funny to see similar PR & issue numbers.
002fd33
to
36286db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am excited to release this feature!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! buttt to double check, has #5635 been completed? otherwise our release will be blocked 😢
The privacy policy update is under review in element-hq/policies#29. I think it only needs typo fixes. @deniseal, do we already know when this is going to be deployed? For the demo video, @mnaturel could you provide a short one? Starting to share (including the permission dialog), showing the location on the timeline and then stopping is probably enough. |
Closing this since the background location permission is not needed, see #6198 |
@Johennes have confirmation from Design that the policy will be live by end of next week. |
Type of change
Content
Moving the background location permission declaration from debug Manifest to release Manifest.
Motivation and context
Closes #6158
Relates to #5635
Screenshots / GIFs
Tests
Tested devices
Checklist