Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Location sharing] - Declare background location permission in release manifest (PSF-1039) #6159

Closed

Conversation

mnaturel
Copy link
Contributor

@mnaturel mnaturel commented May 25, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Moving the background location permission declaration from debug Manifest to release Manifest.

Motivation and context

Closes #6158
Relates to #5635

Screenshots / GIFs

Tests

  • Build the app in release mode
  • Ensure the location sharing is enabled in Settings -> Preferences
  • Ensure live location feature is enabled in Settings -> Labs

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@github-actions
Copy link

github-actions bot commented May 25, 2022

Unit Test Results

142 files  142 suites   2m 16s ⏱️
229 tests 229 ✔️ 0 💤 0
760 runs  760 ✔️ 0 💤 0

Results for commit 36286db.

♻️ This comment has been updated with latest results.

@mnaturel mnaturel marked this pull request as ready for review May 30, 2022 13:22
@mnaturel mnaturel requested review from a team, onurays and fedrunov and removed request for a team May 30, 2022 13:22
@mnaturel mnaturel added the PR-Small PR with less than 20 updated lines label May 30, 2022
@@ -0,0 +1 @@
[Live location sharing] - Declare the background location permission access into the release variant Manifest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is funny to see similar PR & issue numbers.

@mnaturel mnaturel force-pushed the feature/mna/PSF-1039-background-location-permission branch from 002fd33 to 36286db Compare May 30, 2022 13:33
Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am excited to release this feature!

Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! buttt to double check, has #5635 been completed? otherwise our release will be blocked 😢

@Johennes
Copy link
Contributor

Johennes commented May 31, 2022

LGTM! buttt to double check, has #5635 been completed? otherwise our release will be blocked 😢

The privacy policy update is under review in element-hq/policies#29. I think it only needs typo fixes. @deniseal, do we already know when this is going to be deployed?

For the demo video, @mnaturel could you provide a short one? Starting to share (including the permission dialog), showing the location on the timeline and then stopping is probably enough.

@mnaturel
Copy link
Contributor Author

Closing this since the background location permission is not needed, see #6198

@mnaturel mnaturel closed this May 31, 2022
@mnaturel mnaturel deleted the feature/mna/PSF-1039-background-location-permission branch May 31, 2022 09:23
@deniseal
Copy link
Member

LGTM! buttt to double check, has #5635 been completed? otherwise our release will be blocked 😢

The privacy policy update is under review in vector-im/policies#29. I think it only needs typo fixes. @deniseal, do we already know when this is going to be deployed?

@Johennes have confirmation from Design that the policy will be live by end of next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Location PR-Small PR with less than 20 updated lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Location sharing] - Declare background location permission in release Manifest
5 participants