Glide - Use current drawable while loading new static map image (PSF-979) #6103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurays
requested review from
a team,
yostyle and
Claire1817
and removed request for
a team
bmarty
reviewed
May 20, 2022
| @@ -75,6 +75,7 @@ abstract class AbsMessageLocationItem<H : AbsMessageLocationItem.Holder> : AbsMe | |||
| GlideApp.with(holder.staticMapImageView) | |||
| .load(location) | |||
| .apply(RequestOptions.centerCropTransform()) | |||
| .placeholder(holder.staticMapImageView.drawable) | |||
There was a problem hiding this comment.
This fix seems to come from this suggestion: bumptech/glide#2505 (comment)
It's not recommended to use that in RecyclerView, which is the case here (see the comments below).
I should work, but may lead to some issue.
Not a blocker anyway.
There was a problem hiding this comment.
This fix seems to come from this suggestion: bumptech/glide#2505 (comment)
Exactly, I couldn't find any other solutions. I could understand the below comment if we were setting the actual source but we are just setting the placeholder.
- We are going to have a test session next week.
There was a problem hiding this comment.
I'm agree with @bmarty about this fix. Further tests are needed.
yostyle
approved these changes
May 20, 2022
Matrix SDKIntegration Tests Results:
|
mnaturel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interestingly, Glide is clearing current image before the new image is loaded which causes a flicker on timeline item. This PR suggests to use current drawable as placeolder while loading the new static map image.