Crash - Konfetti API 21/22 crash #5926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouchadam
added
Z-Crash
Z-NextRelease
ouchadam
requested review from
a team,
bmarty and
ericdecanini
and removed request for
a team
ouchadam
force-pushed
the
bugfix/adm/konfetti-crash
branch
from
456c503 to
9fd56f0
Compare
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Fixes #5925
The Konfetti v2 upgrade introduce a regression which meant android api 21/22 were no longer able to view the timeline
CompatKonfettiViewMotivation and context
To fix a crash!
Screenshots / GIFs
Tests
Tested devices