Unignore user must perform an initial sync#5767
Merged
Conversation
bmarty
commented
Apr 14, 2022
|
|
||
| <string name="room_participants_action_unignore_title">Unignore user</string> | ||
| <string name="room_participants_action_unignore_prompt_msg">Unignoring this user will show all messages from them again.</string> | ||
| <string name="room_participants_action_unignore_prompt_msg">Unignoring this user will show all messages from them again.\n\nNote that this action will restart the app and it may take some time.</string> |
Member
Author
There was a problem hiding this comment.
I guess this is OK not to create a new string. The translations will be updated one by one, but the use case is not performed a lot.
ariskotsomitopoulos
approved these changes
Apr 14, 2022
Contributor
ariskotsomitopoulos
left a comment
There was a problem hiding this comment.
The PR looks fine. We need the Initial Sync in order to fetch already ignored messages? or there is another reason?
Member
Author
|
Thanks for your fast review!
Yes, the server does not send the message from ignored users to the client. So once the account data is updated, we have to perform a new complete sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Displaying a confirmation dialog when a user is unignored, and perform an init sync when it's done:
Motivation and context
Closes #3439
Screenshots / GIFs
Tests
Tested devices
Checklist