remove spaces feedback from left panel #5686
Conversation
fedrunov
requested review from
a team and
onurays
and removed request for
a team
| class Holder : VectorEpoxyHolder() { | ||
| val feedBackAction by bind<View>(R.id.spaceBetaFeedbackAction) | ||
| } | ||
| class Holder : VectorEpoxyHolder() |
There was a problem hiding this comment.
What do you think about completely deleting SpaceBetaHeaderItem class and item_space_beta_header.xml and improve GenericHeaderItem with a description?
There was a problem hiding this comment.
text appearance of title in item_generic_header is a little bit different, so it will require confirmation from designers. I'd say we should do that as a part of design system implementation, which should happen soon 🤔
onurays
left a comment
onurays
left a comment
There was a problem hiding this comment.
LGTM! I have an improvement suggestion if it will not affect previous usages.
| <string name="you_may_contact_me">You may contact me if you have any follow up questions</string> | ||
| <string name="feedback_sent">Thanks, your feedback has been successfully sent</string> | ||
| <string name="feedback_failed">The feedback failed to be sent (%s)</string> | ||
| <!-- TODO TO BE REMOVED --> |
onurays
left a comment
onurays
left a comment
There was a problem hiding this comment.
ic_feedback drawable should be deleted.
onurays
left a comment
onurays
left a comment
There was a problem hiding this comment.
Can we remove the resource instead of ignoring lint check please?
onurays
left a comment
onurays
left a comment
There was a problem hiding this comment.
Can we remove the resource instead of ignoring lint check please? And we have a conflict.
# Conflicts: # vector/src/main/res/values/strings.xml
Up to the |
onurays
left a comment
onurays
left a comment
There was a problem hiding this comment.
LGTM, thank you for the update!
* develop: (107 commits) Fixes long line and comment lint errors Fixes lint errors Adds changelog file Formats entire project Adds changelog file Makes MediaType internal Bump libphonenumber from 8.12.46 to 8.12.47 updating release version in preparation for next cycle generating changelog Replaces writeAsync with awaitTransaction Replaces doWithRealm with writeAsync Translated using Weblate (Polish) Translated using Weblate (Slovak) Crash: open private room by link. Use RoomId instead of the alias. Translated using Weblate (Arabic) Makes MediaFileUtils function internal Removes runCatching from TemporaryFileCreator using unix end of line character instead of windows as *nix OSes are more common dev environments remove spaces feedback from left panel (#5686) Translated using Weblate (French) ... # Conflicts: # vector/src/main/java/im/vector/app/features/call/VectorCallViewModel.kt
Type of change
Content
removes spaces feedback button from left panel
Motivation and context
closes #5486
Screenshots / GIFs
Tests
-open left panel
Tested devices
Checklist