Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving live location sharing permission to debug #5637

Closed
wants to merge 3 commits into from
Closed

Conversation

ouchadam
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Moves the ACCESS_BACKGROUND_LOCATION permission to the debug AndroidManifest, as including it in the main/release build requires additional steps wen releasing on the Google Play store #5635

Once the feature is complete we can promote it back to the main/release manifest

Motivation and context

Fixes #5636 by matching the current live location build flag (debug only)

Screenshots / GIFs

No UI changes!

Tests

  • Upload to the play store
  • See warning message You must provide information about how your app uses background location permissions, or your app may be removed from Google Play

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 10

@ouchadam ouchadam changed the base branch from develop to main March 25, 2022 15:13
@github-actions
Copy link

github-actions bot commented Mar 25, 2022

Unit Test Results

106 files  ±0  106 suites  ±0   1m 19s ⏱️ +9s
188 tests ±0  188 ✔️ ±0  0 💤 ±0  0 ±0 
622 runs  ±0  622 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit e01c504. ± Comparison against base commit 9ec684f.

♻️ This comment has been updated with latest results.

@ouchadam ouchadam requested a review from bmarty March 28, 2022 08:32
@ouchadam ouchadam marked this pull request as draft March 28, 2022 08:44
@ouchadam
Copy link
Contributor Author

converting to draft whilst updating the version to 1.4.8

@ouchadam ouchadam marked this pull request as ready for review March 28, 2022 10:40
@ouchadam
Copy link
Contributor Author

closing in favour of #5646

@ouchadam ouchadam closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ACCESS_BACKGROUND_LOCATION permission whilst live location sharing is WIP
1 participant