Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a presence sync enabling build config #5566

Merged
merged 4 commits into from
Mar 18, 2022

Conversation

aringenbach
Copy link
Contributor

@aringenbach aringenbach commented Mar 17, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

This PR adds a build config setting to disable Presence sync and display on the client side.

Motivation and context

Fixes #5563

Screenshots / GIFs

Tests

  • Step 1: Set new build config to false
  • Step 2: Connect on a server where Presence is enabled

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 12

Checklist

@github-actions
Copy link

github-actions bot commented Mar 17, 2022

Unit Test Results

102 files  ±0  102 suites  ±0   1m 18s ⏱️ +9s
182 tests ±0  182 ✔️ ±0  0 💤 ±0  0 ±0 
598 runs  ±0  598 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 7593f7a. ± Comparison against base commit 36564d3.

♻️ This comment has been updated with latest results.

@ouchadam
Copy link
Contributor

could be nice to make use of the VectorFeatures if we want to also allow debug runtime overriding instead of only relying on separate builds https://github.com/vector-im/element-android/blob/develop/vector/src/main/java/im/vector/app/features/VectorFeatures.kt#L36

Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update! 💯

@aringenbach aringenbach merged commit 1d74e34 into develop Mar 18, 2022
@aringenbach aringenbach deleted the feature/aringenbach/presence-sync-build-config branch March 18, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a presence sync enabling build config
2 participants