Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification mode] Wrong mode is displayed when the mention only is selected on the web client #5547

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

Claire1817
Copy link
Contributor

@Claire1817 Claire1817 commented Mar 15, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Use none in android application when all messages or mentions only is selected in the web application.
tchapgouv/tchap-android#464

Screenshots / GIFs

Android:
Screenshot_20220315-145528_Element

Web:
Capture d’écran 2022-03-15 à 14 56 00

Tests

  • Update Notification settings in web application to mention only
  • Check if in Android application the notifications preference is equal to None.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@Claire1817 Claire1817 marked this pull request as draft March 15, 2022 14:01
@github-actions
Copy link

github-actions bot commented Mar 15, 2022

Unit Test Results

102 files  +  4  102 suites  +4   1m 5s ⏱️ -5s
182 tests +  3  182 ✔️ +  3  0 💤 ±0  0 ±0 
598 runs  +10  598 ✔️ +10  0 💤 ±0  0 ±0 

Results for commit b073724. ± Comparison against base commit 30c325b.

♻️ This comment has been updated with latest results.

@Claire1817 Claire1817 marked this pull request as ready for review March 15, 2022 14:43
@Claire1817 Claire1817 requested review from a team and fedrunov and removed request for a team March 15, 2022 14:43
Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants