Fixes timeline crash due to additionalTopSpace

[ericdecanini]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Fixes a crash due to a view with id R.id.additionalTopSpace not being found in the base timeline view. This is a view that's only being used in bubbles

Motivation and context

Closes #5535 and https://github.com/matrix-org/element-android-rageshakes/issues/35624

The additionalTopSpace view is only being used in bubbles so I reduced its scope to only the bubbles view rather than the base timeline view.

I also included some slight refactoring of the bubbles view class for readability

Screenshots / GIFs

No UI changes but simple confirmation that top space above bubbles works as expected

Tests

• Open timeline. Observe no crash
• Observe top margin behaviour added in this PR is still present

Tested devices

• Physical
• Emulator
• OS version(s): Android 10

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[github-actions]

Unit Test Results

  98 files  ±  0    98 suites  ±0   1m 6s ⏱️ -8s
178 tests +  4  178 ✔️ +  4  0 💤 ±0  0 ❌ ±0 
584 runs  +16  584 ✔️ +16  0 💤 ±0  0 ❌ ±0 

Results for commit 184b35a. ± Comparison against base commit acfeb7f.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both.

im.vector.app.features.onboarding.OnboardingViewModelTest ‑ when handling display name update then updates upstream user display name

im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given changing profile picture is not supported when updating display name then updates upstream user display name and completes personalization
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given changing profile picture is supported when updating display name then updates upstream user display name and moves to choose profile picture
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given homeserver does not support personalisation when registering account then updates state and emits account created event
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given only supports changing profile picture when handling PersonalizeProfile then emits contents choose profile picture
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given supports changing display name when handling PersonalizeProfile then emits contents choose display name

♻️ This comment has been updated with latest results.

[mnaturel]

Thanks for the fix! Okay for me, just 1 question about changelog entry.

[mnaturel]

I am wondering if this fix needs an entry. Is the crash on the current release?

[ericdecanini]

After several discussions, updated the PR and removed the changelog 👍️