Americanize words/phrases in default en-US strings #5488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
requested changes
Mar 10, 2022
| <string name="settings_discovery_confirm_mail">We sent you a confirm email to %s, check your email and click on the confirmation link</string> | ||
| <string name="settings_discovery_confirm_mail_not_clicked">We sent you a confirm email to %s, please first check your email and click on the confirmation link</string> | ||
| <string name="settings_discovery_confirm_mail">We sent an email to %s. Check your email and click on the confirmation link.</string> | ||
| <string name="settings_discovery_confirm_mail_not_clicked">We sent an email to %s. Check your email and click on the confirmation link.</string> |
There was a problem hiding this comment.
settings_discovery_confirm_mail_not_clicked value has to be different than settings_discovery_confirm_mail.
settings_discovery_confirm_mail_not_clicked is used when the user wants to continue the process to make their email discoverable, but did not click on the link in the email.
Currently we have:
- First displayed screen
- User clicks on "Continue" (but did not click on the link in the email)
|
Hello @downeymj , do you think you will be able to update your PR? There is not a lot to do, but please let us know! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Per @bmarty,
en-USis the default value on Android platform, so I as a native American English speaker I have updated spelling of relevant words and expressions accordingly.Motivation and context
Fixes #3677, which suggested a PR against this file instead of doing things through Weblate. As this is my first PR for this project, hopefully I haven't missed anything, but please let me know if so.
Screenshots / GIFs
N/A
Tests
N/A
Tested devices
N/A
Checklist