Fixing crash adding room by QR code #5296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouchadam
added
Z-Crash
Z-NextRelease
ouchadam
commented
Feb 22, 2022
|
|
||
| private val qrViewModel: QrCodeScannerViewModel by activityViewModel() | ||
| private val scannerArgs: QrScannerArgs? by args() | ||
| private val scannerArgs: QrScannerArgs by args() |
Contributor
Author
There was a problem hiding this comment.
args() can't be null
fun args(): T {
...
return value ?: throw IllegalArgumentException("")
} 
Matrix SDKIntegration Tests Results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Adds missing
QrScannerFragmentarguments when scanning a QR code accept accepting the camera permission for the first timeMotivation and context
Fixes #5295
Screenshots / GIFs
Tests
Tested devices