#5225 Replace color "vctr_unread_room_badge" by "vctr_content_secondary"

[mnaturel]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Replacing the color attribute vctr_unread_room_badge by vctr_content_secondary since it is relying on the same color number.

Motivation and context

See #5225

Screenshots / GIFs

Tests

• Launch the application
• Check notification badge is well displayed in home screen

Tested devices

• Physical
• Emulator
• OS version(s): Android 11

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[github-actions]

Unit Test Results

  84 files  ±0    84 suites  ±0   53s ⏱️ -12s
157 tests ±0  157 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
504 runs  ±0  504 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4713fd9. ± Comparison against base commit 95b3afd.

[github-actions]

Matrix SDK

Integration Tests Results:

• [org.matrix.android.sdk.session]
  passed=
• [org.matrix.android.sdk.account]
  passed=
• [org.matrix.android.sdk.internal]
  passed=
• [org.matrix.android.sdk.ordering]
  passed=
• [org.matrix.android.sdk.PermalinkParserTest]
  passed=

[bmarty]

Perfect, thanks!

[bmarty]

Just one remark, could be nice to add in the description (for next time) something like closes #5225, so that the issue can be closed automatically by GitHub once the PR is merged.

[mnaturel]

Just one remark, could be nice to add in the description (for next time) something like closes #5225, so that the issue can be closed automatically by GitHub once the PR is merged.

Okay I will keep that in mind for my next PR.