Fix back pagination conduit #5168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix SDKIntegration Tests Results:
|
ganfra
reviewed
Feb 7, 2022
| * Synapse is not omitting it and EA was relying on it | ||
| */ | ||
| val chunkEnd = if (receivedChunk.events.isEmpty()) { | ||
| receivedChunk.start |
There was a problem hiding this comment.
ReceivedChunk.start should be the same as the from param, so we will be blocked too, no?
There was a problem hiding this comment.
I think the 'start' is set but 'end' is unset (=null?). Probably chunkEnd=null causes these problems in Element Android
timokoesters
suggested changes
Feb 10, 2022
| * or because the user does not have permission to see any more events), the end property is omitted from the response. | ||
| * Synapse is not omitting it and EA was relying on it | ||
| */ | ||
| val chunkEnd = if (receivedChunk.events.isEmpty()) { |
There was a problem hiding this comment.
Checking events.is_empty is wrong here. There may be events, but if those are the 'last' events in the room, 'end' will not be set.
| * Synapse is not omitting it and EA was relying on it | ||
| */ | ||
| val chunkEnd = if (receivedChunk.events.isEmpty()) { | ||
| receivedChunk.start |
There was a problem hiding this comment.
I think the 'start' is set but 'end' is unset (=null?). Probably chunkEnd=null causes these problems in Element Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5166
@ganfra Could you have a look at it? and check for any side effects?
Basically EA is relying on the
endfield of /messages call, but as per spec it should be omitted if no events .Conduit is doing as per spec, and it's breaking EA back pagination.