Missing fdroid notifications #5012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
reviewed
Jan 20, 2022
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
I am not that sure that they can be side effect. I will read it again.
bmarty
requested changes
Jan 20, 2022
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
(Not sure how to revert approval)
Matrix SDKIntegration Tests Results:
|
bmarty
approved these changes
Jan 21, 2022
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
Ok, I have done more check, I think this is fine!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5003 Fdroid notifications no longer working.
The workaround is to switch the background mode to
optimised for realtimeperiodicflag was no longer being set and instead using the default value offalsehttps://github.com/vector-im/element-android/pull/4614/files#diff-0b0656b4f8d1f73f2a4d5844acec8bf35b732e315e5355800f74145c7fc82fa1L117