-
Notifications
You must be signed in to change notification settings - Fork 906
Storing and tracking the onboarding messaging use case #5009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
84e23e1
storing the user usecase selection and clearinng on signout
ouchadam 515c8ce
adding ability to update the user properties (identity) via the vecto…
ouchadam 6c1cbcc
updating the identity with the use case selection as part of the onbo…
ouchadam 0a7c421
making use of the analytics tracker instead of the vector analytics f…
ouchadam c4ac039
persisting the use case at the point of session creation
ouchadam f44ccd7
storing an retrieving the use case selection by user
ouchadam b91b9cb
lifting analytics extension to the common package
ouchadam 73b80b1
providing the onboarding store via session extension
ouchadam bc37391
making the onboarding store a userId scoped generic store instead
ouchadam cbdeb54
using md5 hash of the userId to normalise the usage as a key
ouchadam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
vector/src/main/java/im/vector/app/features/analytics/extensions/IdentityExt.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* | ||
| * Copyright (c) 2022 New Vector Ltd | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package im.vector.app.features.analytics.extensions | ||
|
|
||
| import im.vector.app.features.analytics.plan.Identity | ||
| import im.vector.app.features.onboarding.FtueUseCase | ||
|
|
||
| fun FtueUseCase.toTrackingValue(): Identity.FtueUseCaseSelection { | ||
| return when (this) { | ||
| FtueUseCase.FRIENDS_FAMILY -> Identity.FtueUseCaseSelection.PersonalMessaging | ||
| FtueUseCase.TEAMS -> Identity.FtueUseCaseSelection.WorkMessaging | ||
| FtueUseCase.COMMUNITIES -> Identity.FtueUseCaseSelection.CommunityMessaging | ||
| FtueUseCase.SKIP -> Identity.FtueUseCaseSelection.Skip | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
vector/src/main/java/im/vector/app/features/session/VectorSessionStore.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /* | ||
| * Copyright (c) 2021 New Vector Ltd | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package im.vector.app.features.session | ||
|
|
||
| import android.content.Context | ||
| import androidx.datastore.core.DataStore | ||
| import androidx.datastore.preferences.core.Preferences | ||
| import androidx.datastore.preferences.core.edit | ||
| import androidx.datastore.preferences.core.stringPreferencesKey | ||
| import androidx.datastore.preferences.preferencesDataStore | ||
| import im.vector.app.features.onboarding.FtueUseCase | ||
| import kotlinx.coroutines.flow.first | ||
|
|
||
| /** | ||
| * Local storage for: | ||
| * - messaging use case (Enum/String) | ||
| */ | ||
| class VectorSessionStore constructor( | ||
| private val context: Context, | ||
| myUserId: String | ||
| ) { | ||
|
|
||
| private val Context.dataStore: DataStore<Preferences> by preferencesDataStore(name = "vector_session_store_$myUserId") | ||
| private val useCaseKey = stringPreferencesKey("use_case") | ||
|
|
||
| suspend fun readUseCase() = context.dataStore.data.first().let { preferences -> | ||
| preferences[useCaseKey]?.let { FtueUseCase.from(it) } | ||
| } | ||
|
|
||
| suspend fun setUseCase(useCase: FtueUseCase) { | ||
| context.dataStore.edit { settings -> | ||
| settings[useCaseKey] = useCase.persistableValue | ||
| } | ||
| } | ||
|
|
||
| suspend fun resetUseCase() { | ||
| context.dataStore.edit { settings -> | ||
| settings.remove(useCaseKey) | ||
| } | ||
| } | ||
|
|
||
| suspend fun clear() { | ||
| context.dataStore.edit { settings -> settings.clear() } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if directly using the
userIdmay lead to some trouble: special chars - low risk, length - higher risk. Maybe using a hash of it would be better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good point, I keep forgetting that user-id is actually a matrix id rather than a uuid, will change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. "Matrix Id" is not really a specific concept, but it is sometimes used for user ids. https://spec.matrix.org/v1.1/appendices/#identifier-grammar is an interesting reading on the subject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cbdeb54