Do not auto-retry on 429 in case of too long retry delay #4995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
approved these changes
Jan 19, 2022
| // 429, we can retry | ||
| delay(exception.getRetryDelay(1_000)) | ||
| val retryDelay = exception.getRetryDelay(1_000) | ||
| if (retryDelay <= maxDelayBeforeRetry) { |
There was a problem hiding this comment.
Maybe update the documentation of maxDelayBeforeRetry to inform that it also has an effect on 429 management.
Matrix SDKIntegration Tests Results:
|
added 2 commits
January 20, 2022 10:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #4950
Propagate the M_LIMIT_EXCEEDED error when the provided delay is too long (exceeds 32 seconds, eg. after three failed login attempts).