Skip to content

Workaround to not to reuse poll option cells #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmarty merged 1 commit into from
Jan 11, 2022
Merged

Workaround to not to reuse poll option cells #4893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/4735.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Polls: unable to create a poll with more than 10 answers
2 changes: 2 additions & 0 deletions vector/src/main/java/im/vector/app/features/poll/create/CreatePollFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import im.vector.app.R
import im.vector.app.core.extensions.configureWith
import im.vector.app.core.platform.VectorBaseFragment
import im.vector.app.databinding.FragmentCreatePollBinding
import im.vector.app.features.poll.create.CreatePollViewModel.Companion.MAX_OPTIONS_COUNT
import kotlinx.parcelize.Parcelize
import javax.inject.Inject

Expand All @@ -51,6 +52,7 @@ class CreatePollFragment @Inject constructor(
vectorBaseActivity.setSupportActionBar(views.createPollToolbar)

views.createPollRecyclerView.configureWith(controller, disableItemAnimation = true)
views.createPollRecyclerView.setItemViewCacheSize(MAX_OPTIONS_COUNT + 4)
controller.callback = this

views.createPollClose.debouncedClicks {
Expand Down
2 changes: 1 addition & 1 deletion vector/src/main/java/im/vector/app/features/poll/create/CreatePollViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class CreatePollViewModel @AssistedInject constructor(
companion object : MavericksViewModelFactory<CreatePollViewModel, CreatePollViewState> by hiltMavericksViewModelFactory() {

const val MIN_OPTIONS_COUNT = 2
private const val MAX_OPTIONS_COUNT = 20
const val MAX_OPTIONS_COUNT = 20
}

init {
Expand Down