Enabling FTUE_AUTH onboarding variant #4872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this flow consistent of feature flag which can enable disable other parts, by default the I already have an account is enabled
ouchadam
commented
Jan 6, 2022
| @@ -0,0 +1 @@ | |||
| Enabling new FTUE Auth onboarding base, includes the "I already have an account" button in the splash | |||
There was a problem hiding this comment.
wasn't sure if this was a .feature or .misc as we're only switching the build config value, could even be a new separate type (if we're able to have custom types)
There was a problem hiding this comment.
OK for misc. I think we are limited by towncrier for possible extension but maybe not.
bmarty
approved these changes
Jan 6, 2022
ouchadam
added
the
Z-FTUE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the build config to point to the
FTUE_AUTHonboarding variant, this variant is a copy of the current (legacy login) with separate feature flags for future changes, eg #4727 and #4585FTUE_AUTHflow also includes FTUE Auth - I already have an account #4668