Small cleanup #4841
Merged
Small cleanup #4841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused methods.
ouchadam
reviewed
Jan 5, 2022
| @RequiresApi(Build.VERSION_CODES.O) | ||
| fun startInstallFromSourceIntent(context: Context, activityResultLauncher: ActivityResultLauncher<Intent>) { | ||
| val intent = Intent(Settings.ACTION_MANAGE_UNKNOWN_APP_SOURCES) | ||
| .setData(Uri.parse(String.format("package:%s", context.packageName))) |
Contributor
There was a problem hiding this comment.
super nit: this was already here but it could be nice to avoid String.format in favour of a more kotlin idiomatic "package:${context.packageName}"
For this usecase it's not very relevant butString.format is also quite heavy relative to a StringBuilder https://cowtowncoder.medium.com/measuring-performance-of-java-string-format-or-lack-thereof-2e1c6a13362c
ouchadam
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused methods.
Following change from PR #4745