Small UI fix in room member profile hearder #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Thanks. |
|
The layout is not correct, see in AS preview:
The shield should be next to the text. |
added 3 commits
December 14, 2021 12:37
bmarty
reviewed
Dec 15, 2021
| app:layout_constraintTop_toBottomOf="@id/memberProfileAvatarView" | ||
| tools:text="@sample/users.json/data/displayName" /> | ||
| android:gravity="center"> |
There was a problem hiding this comment.
Please format the file (and rearrange attributes)
| android:layout_marginEnd="8dp" | ||
| android:gravity="center" | ||
| android:textStyle="bold" | ||
| tools:text=" dezdezdzedez dezjdioezdiozeiodzendez" /> |
There was a problem hiding this comment.
Maybe restore the previous text.
bmarty
approved these changes
Dec 16, 2021
onurays
pushed a commit
that referenced
this pull request
Dec 27, 2021
* develop: (87 commits) Update versions to 1.3.13 Release: prepare CHANGES adding changelog entry removing android version bypass for using text futures - the emoji span changes affect all android versions Update versions to 1.3.12 Release: prepare CHANGES removing trailing space extracting the emoji processing to an interface so that we can override the behaviour in the unit test adding comment to explain SpannableStringBuilder usage adding changelog entry using the safe emoji processor to avoid the timeline failing when processing the content and the emoji library hasn't initialised yet Update changelog.d/4743.bugfix Small UI fix in room member profile hearder (#4700) Add changelog adding changelog entry adding missing binding options emote content - fixes android 12+ crash when certain emojis are used within the emote content Fix crash ImmutableModelException Update Gradle Wrapper from 7.3.1 to 7.3.2. Call banner: center text vertically adding changelog entry ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the room member profile header, when the name is too long the name and the shield are not completely visible.
Screen after the fix:
