select answer should be used for outgoing calls. #4625
Conversation
...x-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/call/model/MxCallImpl.kt
Outdated
Show resolved
Hide resolved
| override fun selectAnswer() { | ||
| Timber.tag(loggerTag.value).v("select answer $callId") | ||
| if (isOutgoing) return | ||
| state = CallState.Answering |
There was a problem hiding this comment.
do we still set this state somewhere else or does CallState.Answering no longer need to exist?
There was a problem hiding this comment.
I guess the initial issue was due to a quick copy paste of the accept fun (https://github.com/vector-im/element-android/blob/main/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/call/model/MxCallImpl.kt#L179)
ouchadam
left a comment
ouchadam
left a comment
There was a problem hiding this comment.
small question around removing the state, otherwise looking good! 💯
ganfra
left a comment
ganfra
left a comment
There was a problem hiding this comment.
Thanks for the fix, my fault for that :/
| override fun selectAnswer() { | ||
| Timber.tag(loggerTag.value).v("select answer $callId") | ||
| if (isOutgoing) return | ||
| state = CallState.Answering |
There was a problem hiding this comment.
I guess the initial issue was due to a quick copy paste of the accept fun (https://github.com/vector-im/element-android/blob/main/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/call/model/MxCallImpl.kt#L179)
...x-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/call/model/MxCallImpl.kt
Outdated
Show resolved
Hide resolved
Fixes #4621
Use case is:
The reason being that if bob tries to accept on two devices, it's clear which one alice is actually trying to connect to.
I believe this problem might have just surfaced recently due to changes at the sip bridge adding a timeout for the
selectAnswer