Devx view ids #4611
Merged
Devx view ids #4611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yout and toolbarId
bmarty
commented
Dec 1, 2021
| ### Use `@id` and not `@+id` when referencing ids in layouts | ||
| layout_(.*)="@\+id | ||
| accessibilityTraversal(.*)="@\+id | ||
| toolbarId="@\+id |
Member
Author
There was a problem hiding this comment.
Those mistakes should not reappear thanks to that new rules
bmarty
commented
Dec 1, 2021
|
|
||
| <!-- | ||
| The aim of this file is to test the different themes of Riot | ||
| The aim of this file is to test the different themes of Element |
bmarty
commented
Dec 1, 2021
| android:layout_height="wrap_content" | ||
| app:layout_constraintEnd_toStartOf="@+id/importDialogShowPassword" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@+id/dialog_e2e_keys_passphrase_filename"> |
Member
Author
There was a problem hiding this comment.
The parent is not anymore in a ConstraintLayout
ouchadam
approved these changes
Dec 2, 2021
Contributor
ouchadam
left a comment
ouchadam
left a comment
There was a problem hiding this comment.
CI is happy and I did a quick local smoke test LGTM 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boring PR about cleaning up the layouts.
Fixes #4604