Skip to content

Voice related sealed class cleanup #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bmarty merged 3 commits into from
Nov 24, 2021
Merged

Voice related sealed class cleanup #4548

bmarty merged 3 commits into from
Nov 24, 2021

Conversation

@ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Nov 23, 2021

Extracted from #4527

  • Renames the UserDraft and SendMode child class names to CamelCase
  • Removes unused base properties from the sealed classes
  • Switches sealed classes to interfaces to help enforce no base properties

@ouchadam ouchadam mentioned this pull request Nov 23, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 23, 2021

Unit Test Results

  66 files  ±0    66 suites  ±0   58s ⏱️ +8s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6838e70. ± Comparison against base commit c72dd5e.

bmarty
bmarty approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit bd423db into develop Nov 24, 2021
@bmarty bmarty deleted the feature/adm/sealed-class-cleanup branch November 24, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmarty bmarty bmarty approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ouchadam @bmarty