Skip to content

Conversation

@ouchadam
Copy link
Contributor

Fixing constant notification sounds when new messages are received, we should only notify for the first (matching the vibration behaviour). FWIW this is the same behaviour as whatsapp.

#3774 (comment)

  • Fixed by making the group summary notification alertOnce to match the grouped child notifications, this means a sound + vibration only happens for new children in the group eg receiving the first message for a new room.

For more background -

…ion once

- fixes notification sounds coming through for every message despite only vibrating for the first
…e/make a sound

- by having the group and child notifications alert once we can safetly always update the group and get consistent alertOnce behaviour
@github-actions
Copy link

github-actions bot commented Oct 14, 2021

Unit Test Results

  44 files  ±0    44 suites  ±0   1m 2s ⏱️ +14s
  87 tests ±0    87 ✔️ ±0  0 💤 ±0  0 ±0 
228 runs  ±0  228 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit eb70a81. ± Comparison against base commit 7ec0872.

♻️ This comment has been updated with latest results.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit 1f74bc9 into develop Oct 14, 2021
@bmarty bmarty deleted the feature/adm/constant-notification-sounds branch October 14, 2021 15:06
@bahur142
Copy link

Hi. I want to report that with this change, now my notification LED also blinks only once for the first message. So I miss many notifications right now.

Also, I think the sounds have to be triggered for every single message. Imagine a situation where I am in the kitchen and the phone is in the living room. Someone message me the same time and will produce sound notification only once. I am back now in the living room. The messages continues to arrive and the phone stays silent, because the sound was triggered only once. It could take hours before I decide to look the phone.

@ouchadam
Copy link
Contributor Author

@bahur142 thanks for providing your example, changes to the notifications can be quite contentious

the opposite example is having your device in front of you whilst being in a busy room and being constantly notified

I'm sure there's a middle ground, will loop in product and raise a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants