-
Notifications
You must be signed in to change notification settings - Fork 857
Constant triggering of notification sounds #4249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ion once - fixes notification sounds coming through for every message despite only vibrating for the first
…e/make a sound - by having the group and child notifications alert once we can safetly always update the group and get consistent alertOnce behaviour
vector/src/main/java/im/vector/app/features/notifications/NotificationUtils.kt
Show resolved
Hide resolved
bmarty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
Hi. I want to report that with this change, now my notification LED also blinks only once for the first message. So I miss many notifications right now. Also, I think the sounds have to be triggered for every single message. Imagine a situation where I am in the kitchen and the phone is in the living room. Someone message me the same time and will produce sound notification only once. I am back now in the living room. The messages continues to arrive and the phone stays silent, because the sound was triggered only once. It could take hours before I decide to look the phone. |
|
@bahur142 thanks for providing your example, changes to the notifications can be quite contentious the opposite example is having your device in front of you whilst being in a busy room and being constantly notified I'm sure there's a middle ground, will loop in product and raise a new issue |
Fixing constant notification sounds when new messages are received, we should only notify for the first (matching the vibration behaviour). FWIW this is the same behaviour as whatsapp.
#3774 (comment)
alertOnceto match the grouped child notifications, this means a sound + vibration only happens for new children in the group eg receiving the first message for a new room.For more background -
onlyAlertOncehowever the group summary was still triggering sounds + vibrations.