Splitting notifications into separate creation and displaying passes#4235

Merged

ouchadam merged 26 commits intofeature/adm/notification-redesignfrom

feature/adm/notification-logic-split

Oct 20, 2021

Commits on Oct 14, 2021

making the event body non null and immutable to allow less cases to be handled -
ouchadam
committed
creating dedicated class for the processing the serialized events
ouchadam
committed
creating the notifications separate to where they're displayed
ouchadam
committed
chaining the event process, notification creation and display logic into a NotificationRender
ouchadam
committed
lifting settings change to cancel all notifications out of the renderer
ouchadam
committed
removing no longer needed hasBeenDisplayed state, the eventList is our source of truth
ouchadam
committed
handling creating the summary when notification events are filtered to empty due to only containing removals
ouchadam
committed
removing this usages for project convention
ouchadam
committed
formatting
ouchadam
committed
ensuring that we removing the summary group before removing individual notifications
ouchadam
committed
relying on the notification refreshing to cancel/update the notifications
ouchadam
committed
splitting the event processing from the rendering
ouchadam
committed
using a process state of keep/removed rather than mapping to an ignored event id
ouchadam
committed
diffing the notification events against the currently rendered events allow us to dismiss notifications from removed events
ouchadam
committed
ensuring that we remove read messages when they come through by respecting the processed type when creating the notifications
ouchadam
committed
adding documentation around the two notifiable event lists which act as our notification source of truth
ouchadam
committed
fixing line lengths
ouchadam
committed
adding missing fixture parameter from rebase
ouchadam
committed
inlining single use extension functions
ouchadam
committed
adding missing parameter from rebase and removing no longer needed singleton annotation
ouchadam
committed
replacing notification utils usage with the displayer and removing unused method
ouchadam
committed
removing unused imports
ouchadam
committed
updating tests with shortcut placement changes
ouchadam
committed
increase enum class allowance by 1
ouchadam
committed

Commits on Oct 19, 2021

using dedicated ProcessedEvent data class instead of type alias for passing around the process notificatiable events
ouchadam
committed

Commits on Oct 20, 2021

renaming event lists to give more context and remove the list suffix/inconsistencies
ouchadam
committed