Notification diffing

[ouchadam]

• Fixes notification related ANR [ANR] NotificationDrawerManager.setCurrentRoom  #4214

  • Splits the event list processing from the notification rendering, this allows the synchronised block to lock for less time (only whilst we process the events)

• Fixes the serialised event list becoming out of sync with the currently rendered notifications, eg receiving multiple room invites

  • Adds event list and currently rendered events diffing, this allows us to remove out of sync notifications

BEFORE	AFTER

[github-actions]

Unit Test Results

  54 files  ±0    54 suites  ±0   44s ⏱️ -6s
107 tests +1  107 ✔️ +1  0 💤 ±0  0 ❌ ±0 
316 runs  +4  316 ✔️ +4  0 💤 ±0  0 ❌ ±0 

Results for commit ea8629e. ± Comparison against base commit 1c35109.

♻️ This comment has been updated with latest results.

[bmarty]

There is a lot PR to be reviewed, I'm wondering if it's worth creating sub PR like that. Also I'm afraid I will have to review the same code when reviewing the PR which want to be merged on develop.
Maybe a big single PR with all the changes regarding the notification management would be better, to be revied and tested only once, but I'm not sure.
WDYT?

[ouchadam]

@bmarty that was my plan 😅 I can close the pending PRs if it's makes the review chain simpler

*all PRs merge into feature/adm/notification-redesign

In order
#4207 duplicate invitation notifications (already merged)
#4182 immutable event data
#4185 splitting creation and displaying logic
#4220 diffing the serialised events vs rendered

finally the feature PR for feature/adm/notification-redesign, which would be for testing or a code review if people want to review all the changes in a single PR instead of broken down

[ouchadam]

closing to avoid ordering confusion