Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/aris/issue 908 user completion picket #4210

Merged
merged 3 commits into from
Oct 11, 2021

Conversation

ariskotsomitopoulos
Copy link
Contributor

Issue #908 Adding trailing space " " or ": " if the user started a sentence by mentioning someone. @ar...


// Adding trailing space " " or ": " if the user started mention someone
val displayNameSuffix =
if (firstChar == "@" && editText.length() == 1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editText.length() == 1. Will it work if the text is "@ar" and the user click on a completion item?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, updating...

@github-actions
Copy link

github-actions bot commented Oct 11, 2021

Unit Test Results

  42 files  ±0    42 suites  ±0   44s ⏱️ -3s
  83 tests ±0    83 ✔️ ±0  0 💤 ±0  0 ±0 
220 runs  ±0  220 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit a2c790b. ± Comparison against base commit 3a387c5.

♻️ This comment has been updated with latest results.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit 737a290 into develop Oct 11, 2021
@bmarty bmarty deleted the feature/aris/issue_908_user_completion_picket branch October 11, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants